Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update stereoscope to latest #1181

Merged
merged 2 commits into from
Aug 29, 2022
Merged

update stereoscope to latest #1181

merged 2 commits into from
Aug 29, 2022

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Aug 29, 2022

Signed-off-by: Christopher Phillips christopher.phillips@anchore.com

@spiffcs
update stereoscope to latest
359fcea 
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs spiffcs enabled auto-merge (squash) August 29, 2022 18:38
@github-actions
Copy link

github-actions bot commented Aug 29, 2022 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    13.2ms ± 1%    11.4ms ±23%     ~     (p=0.190 n=4+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.49ms ± 1%    1.26ms ± 3%  -15.59%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.74ms ± 3%    3.11ms ± 4%  -16.72%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.22ms ± 2%    1.00ms ± 1%  -17.70%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         865µs ± 1%     714µs ± 7%  -17.42%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.01ms ± 2%    0.83ms ± 1%  -18.18%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                     1.47ms ± 1%    1.20ms ± 1%  -18.51%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      16.7ms ± 1%    14.2ms ± 4%  -14.58%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.39ms ± 1%    1.23ms ± 2%  -11.60%  (p=0.016 n=4+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.51µs ± 2%    2.07µs ± 2%  -17.64%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.55ms ± 2%    1.29ms ± 1%  -17.05%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    818µs ± 3%     669µs ± 1%  -18.15%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               202kB ± 0%     202kB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             944kB ± 0%     944kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     214kB ± 0%     214kB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         158kB ± 0%     158kB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     203kB ± 0%     203kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      302kB ± 0%     302kB ± 0%     ~     (p=0.310 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.44MB ± 0%    3.44MB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%     ~     (p=0.730 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                369kB ± 0%     369kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    136kB ± 0%     136kB ± 0%     ~     (p=0.333 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=0.397 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.25k ± 0%     4.25k ± 0%     ~     (p=0.238 n=5+4)
ImagePackageCatalogers/python-package-cataloger-2             16.6k ± 0%     16.6k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.53k ± 0%     5.53k ± 0%     ~     (p=0.571 n=4+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.32k ± 0%     3.32k ± 0%     ~     (p=0.333 n=5+4)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.60k ± 0%     4.60k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      8.12k ± 0%     8.12k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.246 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.43k ± 0%     5.43k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.27k ± 0%     7.27k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.59k ± 0%     3.59k ± 0%     ~     (p=1.000 n=5+5)

@tri-adam tri-adam mentioned this pull request Aug 29, 2022
Closed
@spiffcs
Copy link
Contributor Author

spiffcs commented Aug 29, 2022

Thanks @tri-adam for all the help and support on this! Releasing this afternoon when this merges

@spiffcs
go mod tidy
0343654 
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@tri-adam
Copy link
Contributor

Thanks @tri-adam for all the help and support on this! Releasing this afternoon when this merges

My pleasure! Thanks for pulling that in here so quickly... looking forward to testing out the release.

@spiffcs spiffcs merged commit a7966a4 into main Aug 29, 2022
@spiffcs spiffcs deleted the stereoscope-update-squashfs branch August 29, 2022 19:28
cpendery pushed a commit to cpendery/syft that referenced this pull request Sep 11, 2022
@spiffcs @cpendery
update stereoscope to latest (anchore#1181)
d06320c
aiwantaozi pushed a commit to aiwantaozi/syft that referenced this pull request Oct 20, 2022
@spiffcs @aiwantaozi
update stereoscope to latest (anchore#1181)
7cec045
spiffcs added a commit that referenced this pull request Oct 21, 2022
@spiffcs
update stereoscope to latest (#1181)
056358d 
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
spiffcs added a commit that referenced this pull request Oct 21, 2022
@spiffcs
update stereoscope to latest (#1181)
bf3773c 
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@spiffcs
update stereoscope to latest (anchore#1181)
e802ba3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spiffcs @tri-adam @wagoodman